Patchworkβ smtp-dummy: clear sockaddr_in structure before use in bind()

login
register
about
Submitter Tomi Ollila
Date 2011-11-12 09:57:22
Message ID <yf68vnlll31.fsf@taco2.nixu.fi>
Download mbox | patch
Permalink /patch/1492/
State New
Headers show

Comments

Tomi Ollila - 2011-11-12 09:57:22
Any junk bytes in sockaddr_in structure before passing that
to bind() system call may cause problems.
---

Thanks Austin. Consistent style matters... And dropped the peer_addr
setting after reading accept(2) namual page.

 test/smtp-dummy.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
David Bremner - 2011-11-12 12:55:34
On Sat, 12 Nov 2011 11:57:22 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> Any junk bytes in sockaddr_in structure before passing that
> to bind() system call may cause problems.
> ---

Pushed the second version.

d

Patch

diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c
index 9da8202..1778a45 100644
--- a/test/smtp-dummy.c
+++ b/test/smtp-dummy.c
@@ -159,6 +159,7 @@  main (int argc, char *argv[])
 		return 1;
 	}
 
+	memset (&addr, 0, sizeof (addr));
 	addr.sin_family = AF_INET;
 	addr.sin_port = htons (25025);
 	addr.sin_addr = *(struct in_addr *) hostinfo->h_addr;